test_formulae: avoid trying to install unavailable bottle

[cho-m]

Issue was seen in Homebrew/homebrew-core#193114 where cgal cannot fetch a qt bottle as it wasn't built on Sequoia and test runner does not download Sonoma bottles.

Not sure yet if this does what I want.

[carlocab]

Do you have a link to the error log?

[cho-m]

Do you have a link to the error log?

Will need to wait for run to finish as I saw it before scroll limit. If any prior run still has log, I'll add link here.

EDIT: Last run: https://github.com/Homebrew/homebrew-core/actions/runs/11547656218/job/32190704667#step:3:921

[carlocab]

Gotcha, thanks.

I wonder if it makes more sense to handle this here:

homebrew-test-bot/lib/tests/formulae_dependents.rb

Line 109 in f4dfaa5

def dependents_for_formula(formula, formula_name, args:)

Maybe somewhere here?

homebrew-test-bot/lib/tests/formulae_dependents.rb

Lines 165 to 183 in f4dfaa5

	# Split into dependents that we could potentially be building from source and those
	# we should not. The criteria is that a dependent must have bottled dependencies, and
	# either the `--build-dependents-from-source` flag was passed or a dependent has no
	# bottle on the current OS.
	source_dependents, dependents = dependents.partition do |dependent, deps|
	next false if OS.linux? && dependent.requirements.exclude?(LinuxRequirement.new)
	all_deps_bottled_or_built = deps.all? do |d|
	bottled_or_built?(d.to_formula, @dependent_testing_formulae)
	end
	args.build_dependents_from_source? && all_deps_bottled_or_built
	end
	# From the non-source list, get rid of any dependents we are only a build dependency to
	dependents.select! do |_, deps|
	deps.reject { |d| d.build? && !d.test? }
	.map(&:to_formula)
	.include?(formula)
	end

source_dependents and dependents both look like arrays of the form

[[foo, foo_deps], [bar, bar_deps], ....]

so we can just cycle through the outer array to check the second member of each inner array for skipped_or_failed_formulae.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.