jp2a: downgrade from 1.0.7 to 1.0.6

[IllyaMoskvin]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

Continuing discussion from the "Downgrade jp2a formula to v1.0.6" Discourse thread. As requested by @SMillerDev, I'm opening a PR. I'm copying the details from that post here.

The jp2a formula is currently "broken" and has been since #39096, which was meant to acknowledge the migration of jp2a's source repository from SourceForge to Github.

However, jp2a's migration to GitHub was not a smooth transition. Its GitHub repository is lacking v1.0.6, which was available on SourceForge. The only release on GitHub is v1.0.7, which turned out to be a "dud" in the sense that it contained various issues that were not immediately obvious by just running test.jpg through it.

I'm not personally aware of all the errors in v1.0.7, but these issues are well-known enough that the MacPorts community has intentionally kept their jp2a package at v1.0.6:

cslarsen/jp2a#8

Unfortunately, there has been no action on part of the author to tag a v1.0.8 for 3 years. However, jp2a v1.0.6, which is still available from SourceForge, works great.

Can we please revert this formula to point at v1.0.6 on SourceForge? This PR is my attempt to do so, but I'm not sure how to go about reverting to an earlier version. The test ran fine, but the audit produced this error:

imoskv$ brew audit --strict jp2a
jp2a:
  * stable version should not decrease (from 1.0.7 to 1.0.6)
Error: 1 problem in 1 formula detected

[Bo98]

I'm not sure how to go about reverting to an earlier version

Add version_scheme 1 instead of revision 1 and put a very clear comment in the formula file stating that 1.0.7 should not be used and why, with reference to upstream's recommendation to use 1.0.6.

[IllyaMoskvin]

Thanks! I did as requested, but I'm now getting an error about revisions:

$ brew audit --strict jp2a
jp2a:
  * revision should not decrease (from 1 to 0)
Error: 1 problem in 1 formula detected

Is this because revision 1 was already specified for 1.0.6 before?

https://github.com/Homebrew/homebrew-core/blob/31b5579/Formula/jp2a.rb

Above is the last commit to this formula before the #39096 merge.

Let me know if you need me to squash and/or rebase before merging this.

[IllyaMoskvin]

I restored revision 1 and brew audit --strict jp2a now runs without error.

Sorry to bump, but what are your thoughts? Is this merge-ready, or does it need more work?

[Bo98]

I'm not sure if the audit is correct, but in the end it doesn't actually matter.

Thank you @IllyaMoskvin. I'll merge this now.