iconsur: avoid Xcode.app dependency #198527
Merged
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
added
CI-no-bottles
github-actions
bot
added
nodejs
|
May not be needed after ronaldoussoren/pyobjc@864a218. |
cho-m
changed the title
cho-m
force-pushed
the
iconsur-xcode
branch
3 times, most recently
from
133a666
to
5083fe8
Compare
cho-m
changed the title
chenrui333
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to check if adding dependency helps fix build on older macOS, which may have been broken after dropping hardcoded CLT.
May need a
SYSROOT/SDKROOT/MACOSX_DEPLOYMENT_TARGETfix.