Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
Fixes a race between setting the debug log output on
DoltDb
and running statistics configuration.call dolt_stats_prune()
should wipe the stats database disk contents, and replace with the currently tracked statistics. This is GC-like behavior.call dolt_stats_purge()
should clear the stats database folder and reinitialize it empty. It's equivalent torm -rf .dolt/stats
and thendolt init
ing a new stats directory.TODO: more testing and docs
go-mysql-server
These aren't used anywhere, so it's getting removed.
Partition still exists if we ever want to reimplement some version of this.
plan.QueryProcess
and move logic tofinalizeIters
This PR removes the use of
plan.QueryProcess
and part of thetrackProcess
rule that adds/removes this node.Instead the
TrackedRowIter
is created directly infinalizeIters
.selectExprNeedsAlias
to consider string literal quotesWhen fixing a string literal quoting issue in Doltgres (More
ALTER TABLE
Support dolthub/doltgresql#868), table functions stopped working, because theselectExprNeedsAlias
started returningtrue
to indicate that an alias was needed (even though it wasn't) and thebuildTableFunc
function would fail.This started happening because the quoted string literals no longer matched
InputExpression
, sinceInputExpression
always trims off quotes when it is assigned. Another solution could be to expose thetrimQuotes
function from Vitess and use it to trimexpr.String()
before matching againstInputExpression
.LOAD DATA
64K buffer limitThis PR increase the buffer size for
bufio.Scanner
toLongTextMax
, so hopefully nobody attempts to load a single row larger than 4GB.Other changes:
loadDataIter
scanner.Text()
logicbenchmark: bump test dolthub/dolt#8467
fixes:
LOAD DATA LOCAL INFILE
fails when row size exceeds 64K (65535 bytes) limit dolthub/dolt#8469doltgres fix: rule changes dolthub/doltgresql#872
Resolves #2701
Closed Issues
LOAD DATA LOCAL INFILE
fails when row size exceeds 64K (65535 bytes) limit