Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
companion pr: only check references for updated columns dolthub/go-mysql-server#2690
go-mysql-server
This PR cleans up the logic surrounding warnings and clearing them.
The important part was separating the number of "new" warnings from the list of warnings themselves.
Every query should clear out the warnings from the previous query. The exception is
show warnings
, which only clears the "count" of warnings.When a server runs a query that produces a warning, it immediately calls
show warnings
. Since theshow warnings
query itself should NOT clear the warnings, the warning count would always be > 0, and incorrectly indicate thatshow warnings
produced a warning. This causes an infinite loop in.NET
. Now, we always clear the warning count, and only clear the warnings themselves when the query is notshow warnings
.We've also had this weird problem of having to double clear warnings, which this should address.
fixes:
information_schema.columns
This PR has information_schema reparse create view statements to fill in missing information for the
information_schema.columns
table. There maybe small differences in column type for more complex views, but should be fine.Implementing using
view.TextDefinition
would be slightly easier/cleaner, but for some reason its sometimes empty? Seems like something to do with fragments on dolt side.fixes:
information_schema.columns
does not contain all associated view information dolthub/dolt#3168fixes: Dolt doesn't update enum/set values when the type is changed dolthub/dolt#7472
fixes: When updating rows, Dolt requires all values in the row to satisfy constraints, not just the values changed dolthub/dolt#2690
This provides support for
show tables from public
andshow table from mydb.public
in postgres dialects.Closed Issues
information_schema.columns
does not contain all associated view information