Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
"$user"
schemapg_am
tableThis allows displaying index information on TablePlus
Fixes column resolution problems when using subqueries in joins.
Partially addresses Column alias from subquery cannot be referenced in join dolthub/doltgresql#554
Tuples won't work until we have a doltgres tuple type, but should work for everything else.
New expression type is a combination of InTuple from Doltgres and InSubquery from GMS. GMS code couldn't really be reused usefully.
The context finalizer node was implemented incorrectly in terms of the semantics required for subquery logic to function -- the top-level child was never being considered in the row-prepend process.
IN clauses with subqueries still do not work, that's next.
depends on handle view resolution when the schema is not defined in SELECT stmt dolthub/go-mysql-server#2633
The problem: the varchar type in
pgtypes
was declared asText
, notVarchar
. This triggered validation checks in both GMS and Dolt when such a column was used in a primary key. I originally tried adding additional index / length info in theCREATE TABLE
transformation, but with the varchar type being interpreted asText
, there's no combination of params that can satisfy all the validation checks.The error before this fix is e.g.
Collation / charset support is still fake and will need to be fixed, but no worse than it was before.
unknown
type for string literalThis PR also adds some build in functions:
pg_get_indexdef
- parsespg_indexes_size
- parsespg_tables_size
- parsespg_total_relation_size
- parsesGMS PR: [no-release-notes] Support information_schema.schemata hook for doltgres dolthub/go-mysql-server#2632
Closed Issues
show create table
andshow tables
should not workcurrent_schema()
not yet supported