Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stellar-cli 21.3.0 (new formula) #180191

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

leighmcculloch
Copy link
Contributor

@leighmcculloch leighmcculloch commented Aug 6, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Add formula for stellar-cli 21.3.0 an accompanying tool to the existing stellar-core formula.

Close stellar/stellar-cli#1446

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Aug 6, 2024
@leighmcculloch leighmcculloch marked this pull request as ready for review August 6, 2024 06:10
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few comments.

Formula/s/stellar-cli.rb Outdated Show resolved Hide resolved
Formula/s/stellar-cli.rb Outdated Show resolved Hide resolved
Formula/s/stellar-cli.rb Outdated Show resolved Hide resolved
Formula/s/stellar-cli.rb Outdated Show resolved Hide resolved
Formula/s/stellar-cli.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 9, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 9, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 9, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 9, 2024
Merged via the queue into Homebrew:master with commit ab27ada Aug 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make installing binary releases a native experience
4 participants