Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lux: fix test #162073

Merged
merged 1 commit into from
Feb 8, 2024
Merged

lux: fix test #162073

merged 1 commit into from
Feb 8, 2024

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Feb 7, 2024

Old test image URL https://github.githubassets.com/images/modules/site/icons/footer/github-logo.svg gives 404 now due to github site changes:

Testing lux
  ==> /opt/homebrew/Cellar/lux/0.22.0/bin/lux -i https://github.githubassets.com/images/modules/site/icons/footer/github-logo.svg
  Downloading https://github.githubassets.com/images/modules/site/icons/footer/github-logo.svg error:
  https://github.githubassets.com/images/modules/site/icons/footer/github-logo.svg request error: HTTP 404

Observed in

but will show up also in

in the next test run

Changed to an image https://upload.wikimedia.org/wikipedia/commons/c/c2/GitHub_Invertocat_Logo.svg that is not subject to an unexpected site redesign.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Test image URL gives 404 now.
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Feb 7, 2024
@stefanb stefanb mentioned this pull request Feb 7, 2024
1 task
@p-linnane p-linnane added the CI-no-bottles Merge without publishing bottles label Feb 8, 2024
@p-linnane p-linnane added this pull request to the merge queue Feb 8, 2024
Merged via the queue into Homebrew:master with commit 72745d1 Feb 8, 2024
20 checks passed
@stefanb stefanb deleted the patch-3 branch February 8, 2024 05:47
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants