Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grin-wallet: add build patch for rust 1.71.0 #137857

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

followup of #136514
relates to mimblewimble/grin-wallet#684

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Jul 28, 2023
@chenrui333 chenrui333 added CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. linux Linux is specifically affected labels Jul 28, 2023
@chenrui333
Copy link
Member Author

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Jul 28, 2023
@chenrui333
Copy link
Member Author

close the PR for now, this issue needs to be resolved first before reopening it

@chenrui333 chenrui333 closed this Aug 10, 2023
@ardocrat
Copy link

I had the same issue under Arch Linux with GCC 13.2.1, updating croaring crate to 0.5.2 fixed the issue, I opened PR: mimblewimble/grin#3770. Maybe it will help for Mac too.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
@chenrui333 chenrui333 deleted the grin-wallet-add-rust-1.71.0-build-patch branch January 22, 2024 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. linux Linux is specifically affected outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants