Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onscripter: remove livecheck #124013

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

samford
Copy link
Member

@samford samford commented Feb 23, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The onscripter formula was deprecated in #122360, as it relies on deprecated SDL v1 packages. onscripter was most recently updated on 2022-08-16 but it's moot unless there's an intention to migrate to SDL2, so this PR removes the livecheck block to allow the formula to be automatically skipped as deprecated.

@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 23, 2023
@BrewTestBot BrewTestBot added lua Lua use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Feb 23, 2023
@nandahkrishna nandahkrishna merged commit 5cf7e84 into Homebrew:master Feb 23, 2023
@samford samford deleted the onscripter-remove-livecheck branch February 23, 2023 14:17
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated livecheck Issues or PRs related to livecheck lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants