detekt 1.22.0: Add --add-opens java.base/java.lang=ALL-UNNAMED for openjdk@17

[rowi1de]

• Fixes detekt 1.22.0: Dependency on openJdk@17: Missing module options (java.lang.reflect.InaccessibleObjectException [...] module java.base does not "opens java.lang" to unnamed module) #116784
• Using https://rubydoc.brew.sh/Pathname#write_jar_script-instance_method

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[SMillerDev]

Is there no upstream patch for this yet?

[rowi1de]

Is there no upstream patch for this yet?

Unfortunately not and this error was introduced to the Formular in https://github.com/Homebrew/homebrew-core/blame/04c92a907a3c0a1cefa2e22aeee8a39cae9d47f6/Formula/detekt.rb#L17 when upgrading the JDK

[SMillerDev]

Is there an upstream issue we can reference to know when we can remove this workaround?

[rowi1de]

Is there an upstream issue we can reference to know when we can remove this workaround?

It was discovered here detekt/detekt#5247 (comment)
as detekt wraps ktlint pinterest/ktlint#1195 which will send you here: https://youtrack.jetbrains.com/issue/KT-43704

most similar upstream issue pinterest/ktlint#1618

however this fix reduces the chance of the Formular / tool breaking in the future to to similar upstream changes

[SMillerDev]

This does highlight an issue in detekt itself though, which I'll look into further

This comment there has me a bit worried. It might hide the symptoms if we merge this PR. But does it really fix anything?

[rowi1de]

This does highlight an issue in detekt itself though, which I'll look into further

This comment there has me a bit worried. It might hide the symptoms if we merge this PR. But does it really fix anything?

Yes 👍🏼 it makes the installed tool usable again.
Try the following:
#116784 (comment)
by just installing detekt with the unfixed Formular and this fixed one.

[3flex]

This does highlight an issue in detekt itself though, which I'll look into further

That comment was from me. There's nothing we can change in detekt itself to fix this. All I meant by that comment was that the generated scripts used by detekt itself don't currently include that flag, but should, so it's fixed for other users who are using the CLI distribution of detekt.

I'd suggest actually changing the homebrew script to download the ZIP (e.g. detekt-cli-1.22.0.zip), then call /path/to/unzipped/location/bin/detekt-cli. That script should include the workaround in a future release. But for 1.22.0 you will want the workaround proposed here.

[3flex]

Actually it might be possible to fix this for the JAR as well by adding an appropriate Add-Opens attribute to MANIFEST.MF. I will need to test.

Regardless of how we manage this in detekt itself though, this workaround is required in the formula file to make v1.22.0 work in brew. The workaround might not be required for future versions, you can track this for updates: detekt/detekt#5576

[BrewTestBot]

🤖 A scheduled task has triggered a merge.