-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polyphone: update 2.5.1 and add legacy macOS ver. #198812
base: master
Are you sure you want to change the base?
polyphone: update 2.5.1 and add legacy macOS ver. #198812
Conversation
Casks/p/polyphone.rb
Outdated
|
||
name "Polyphone" | ||
desc "Soundfont editor for quickly designing musical instruments" | ||
homepage "https://www.polyphone.io/en" | ||
|
||
depends_on macos: ">= :monterey" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line will cause the older version to not be installable for Monterey and older.
version "2.5.0,124" | ||
sha256 "031ad6ab2dc78841aefd5159d35194ffcf197d4845f3a084f0e0e5bb438d962b" | ||
on_big_sur :or_older do | ||
version "2.5-1,130" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried with a variable
macos_version = "-MacOS_12"
on_big_sur :or_older do
version "2.5.1,130"
sha256 "03b3509f8a6af45a7de6b93aeaf62bf5fae552aba7806b0ac46cf24ba57f37e3"
macos_version = "_MacOS_10.13"
end
on_monterey :or_newer do
version "2.5.1,129"
sha256 "89a60fc2444a4502719d23f2d5404a1fa9677db64ef09267ebced0eddf77a0dc"
end
How about this? Then the remaining part can be used commonly.
next if match.blank? | ||
livecheck do | ||
url "https://www.polyphone.io/en/software" | ||
regex(/file_id=(\d+)" title="Download the file “Polyphone_MacOS_10\.13-(\d+(?:[\.-]\d+)+)/i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.5-1 is now changed to 2.5.1.
regex(/file_id=(\d+)"\s+title=".*Polyphone[._-]MacOS_10\.13[._-]v?(\d+(?:\.\d+)+)\.dmg/i)
or
regex(/file_id=(\d+)"\s+title=".*Polyphone#{macos_version}[._-]v?(\d+(?:\.\d+)+)\.dmg/i)
as a common manner.
will fix later, I'm currently sick |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.