shortwave 2024.11.03 (new cask)

[gwtaylor]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

Additionally, if adding a new cask:

• Named the cask according to the token reference.
• Checked the cask was not already refused (add your cask's name to the end of the search field).
• brew audit --cask --new <cask> worked successfully.
• HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
• brew uninstall --cask <cask> worked successfully.

---

I was surprised that there was nothing to add to zap trash. Here is what I did to verify:

• Inspected all paths created within 30 minutes of installing and using the app
• Search ~/Library for 'Shortwave' (case insensitive)
• Check the obvious paths manually: ~/Library/Application Support, ~/Library/Preferences.

[bevanjkay]

Suggested change

	livecheck do
	url :url
	strategy :extract_plist do |items|
	items["com.electron.shortwave"]&.bundle_version&.short_version
	end
	end
	livecheck do
	url "https://storage.googleapis.com/shortwave-downloads/desktop_app/darwin/#{arch}/RELEASES.json"
	strategy :json do |json|
	json["currentRelease"]
	end
	end

[bevanjkay]

Suggested change

	url "https://storage.googleapis.com/shortwave-downloads/desktop_app/darwin/#{arch}/Shortwave%20Installer%20(#{arch}).dmg",
	url "https://storage.googleapis.com/shortwave-downloads/desktop_app/darwin/#{arch}/Shortwave-darwin-#{arch}-#{version}.zip",

[bevanjkay]

Suggested change

	desc "Email client desktop application"
	desc "Email client"

[bevanjkay]

Suggested change

	zap trash: []
	zap trash: [
	"~/Library/Application Support/Shortwave",
	"~/Library/Application Support/com.apple.sharedfilelist/com.apple.LSSharedFileList.ApplicationRecentDocuments/com.electron.shortwave.sfl3",
	"~/Library/Caches/com.electron.shortwave",
	"~/Library/Caches/com.electron.shortwave.ShipIt",
	"~/Library/HTTPStorages/com.electron.shortwave",
	"~/Library/Logs/Shortwave",
	"~/Library/Preferences/com.electron.shortwave.plist",
	"~/Library/Saved Application State/com.electron.shortwave.savedState",
	]

[bevanjkay]

Suggested change

	depends_on macos: ">= :catalina"
	auto_updates true
	depends_on macos: ">= :catalina"

[bevanjkay]

Thank you @gwtaylor - I have left some review comments.
The methods linked here surfaced some zap paths. Specifically brew createzap.