Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tageditor: update livecheck #190050

Closed
wants to merge 1 commit into from
Closed

tageditor: update livecheck #190050

wants to merge 1 commit into from

Conversation

khipp
Copy link
Member

@khipp khipp commented Oct 28, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Related to #171006.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Oct 28, 2024
@krehel
Copy link
Member

krehel commented Oct 28, 2024

This gets updated in place, so I think the second build version number is required to let users know the same version has been updated.

@khipp
Copy link
Member Author

khipp commented Oct 28, 2024

Thanks for catching that! Closing this one.

@khipp khipp closed this Oct 28, 2024
@khipp khipp deleted the update-tageditor branch October 28, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants