Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce finalized sorbet methods #18801

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Enforce finalized sorbet methods #18801

merged 1 commit into from
Nov 22, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Nov 22, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We have a few methods marked :final:

$ git grep 'sig(:final)'
Library/Homebrew/downloadable.rb:  sig(:final) { returns(T::Boolean) }
Library/Homebrew/formula.rb:  sig(:final) {
Library/Homebrew/requirement.rb:  sig(:final) {
Library/Homebrew/requirement.rb:  sig(:final) { returns(T::Boolean) }
Library/Homebrew/requirement.rb:  sig(:final) {

However, per sorbet docs, enforcement requires an incantation of T::Configuration.enable_final_checks_on_hooks setup.

I've made that change here, added a test that a specific finalized method can't be overriden, and done some other minor sorbet tuning.

@dduugg dduugg force-pushed the enforce-final branch 4 times, most recently from db374d6 to 72694e5 Compare November 22, 2024 02:32
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dduugg!

@MikeMcQuaid MikeMcQuaid merged commit 3a5b17a into master Nov 22, 2024
28 checks passed
@MikeMcQuaid MikeMcQuaid deleted the enforce-final branch November 22, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants