env_config: infer HOMEBREW_FORBID_PACKAGES_FROM_PATHS from HOMEBREW_DEVELOPER #18379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EVELOPER If `HOMEBREW_DEVELOPER` is not set, then let's make `HOMEBREW_FORBID_PACKAGES_FROM_PATHS` default to true. I used a custom implementation here because we don't currently support setting defaults for booleans. (See calls to `define_method` below.) Closes #18371.
|
Since this is a breaking change, we may want to save this for a minor release. |
|
Looks like a lot of tests will need fixing. |
MikeMcQuaid
approved these changes
Sep 23, 2024
Comment on lines
+538
to
+540
| ENVS.fetch(:HOMEBREW_FORBID_PACKAGES_FROM_PATHS) | ||
| .fetch(:default) | ||
| .call |
There was a problem hiding this comment.
Suggested change
| ENVS.fetch(:HOMEBREW_FORBID_PACKAGES_FROM_PATHS) | |
| .fetch(:default) | |
| .call | |
| developer? |
feels a bit nice?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I'll get to this late next week (or in the first half of the week following that). Note: I'm not optimistic about being able to fix the test failures, so I may just end up closing this after working on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?If
HOMEBREW_DEVELOPERis not set, then let's makeHOMEBREW_FORBID_PACKAGES_FROM_PATHSdefault to true.I used a custom implementation here because we don't currently support
setting defaults for booleans. (See calls to
define_methodbelow.)Closes #18371.