Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crate linter attributes #15

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Conversation

uklotzde
Copy link
Contributor

Minor dependency updates and my current standard set of linter attributes.

@uklotzde uklotzde force-pushed the crate-linter-attributes branch from ac51ba8 to e1ef7cf Compare January 29, 2022 16:47
@uklotzde
Copy link
Contributor Author

Ping ;)

@Holzhaus
Copy link
Owner

Holzhaus commented Feb 2, 2022

When I merge this into a local branch, pre-commit fails:

$ git checkout main
$ git checkout -b test
$ git pull https://github.com/uklotzde/triseratops.git crate-linter-attributes
$ pre-commit run --from-ref main --to-ref HEAD
[...]
fmt......................................................................Failed
- hook id: fmt
- exit code: 1

Invalid value for `--edition`
Invalid value for `--edition`
Invalid value for `--edition`
Invalid value for `--edition`
Invalid value for `--edition`

cargo check..............................................................Failed
- hook id: cargo-check
- exit code: 101

   Compiling memchr v2.3.4
   Compiling regex-syntax v0.6.25
    Checking cfg-if v1.0.0
    Checking adler v0.2.3
    Checking minimal-lexical v0.2.1
   Compiling triseratops v0.0.2 (/home/jan/Projects/triseratops)
    Checking byteorder v1.4.2
    Checking unicode-width v0.1.8
    Checking smawk v0.3.0
   Compiling nom v7.1.0
    Checking libc v0.2.82
error: edition 2021 is unstable and only available with -Z unstable-options.

error: could not compile `triseratops`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

clippy...................................................................Failed
- hook id: clippy
- exit code: 101

   Compiling triseratops v0.0.2 (/home/jan/Projects/triseratops)
   Compiling memchr v2.3.4
   Compiling nom v7.1.0
    Checking crc32fast v1.2.1
    Checking miniz_oxide v0.4.3
error: edition 2021 is unstable and only available with -Z unstable-options.

error: could not compile `triseratops`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

@Holzhaus
Copy link
Owner

Holzhaus commented Feb 2, 2022

Weird, the 2021 edition was already introduced in #12 but I didn't notice the issues until now 🤷

@Holzhaus
Copy link
Owner

Holzhaus commented Feb 2, 2022

Ooof, I managed to mess up my local rust install. Switched back to stable rust 1.58.1 from the Arch repos, now everything works fine.

@Holzhaus Holzhaus merged commit cc68f7d into Holzhaus:main Feb 2, 2022
@uklotzde uklotzde deleted the crate-linter-attributes branch February 2, 2022 20:17
@Holzhaus Holzhaus added this to the 0.0.2 milestone Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants