Try to make entire library Cumulative #1710
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP to show what fails when you try to make the entire library Cumulative. I didn't put much effort into this.
Algebra/Universal/Homomorphism.v:
homomorphism_id
fails, and I didn't immediately see a quick fix. So I marked one thing in that file as NonCumulative.Modalities/Descent.v: I added a comment near the failing part here, and again wasn't sure how to fix it.
Classes/theory/premetric.v: I didn't investigate.
Sets/Hartogs.v: I didn't investigate.
Categories/Comma/ProjectionFunctors.v: spins.
There may be more failures when dependencies of those files are built, but the good news is that 406 files (out of 578) built fine, so I would guess that there will be around 2 or 3 other files with issues.