[sc-484] Optimize pre-reduce pass #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #484: Optimize hvm-core pre-reduce pass. |
FranchuFranchu
changed the base branch from
main
to
feature/sc-481/add-transformation-passes
FranchuFranchu
commented
Mar 1, 2024
tests/snapshots/tests__pre_reduce_run@sort__bitonic__bitonic_sort_ctr.hvmc.snap
Outdated
Show resolved
Hide resolved
tjjfvi
reviewed
Mar 1, 2024
tjjfvi
reviewed
Mar 1, 2024
tjjfvi
reviewed
Mar 1, 2024
|
(marking this as draft since it's based on another PR) |
tjjfvi
reviewed
Mar 4, 2024
FranchuFranchu
force-pushed
the
feature/sc-481/add-transformation-passes
branch
3 times, most recently
from
6e57884 to
51ba02f
Compare
Base automatically changed from
feature/sc-481/add-transformation-passes
to
main
March 4, 2024 15:26
FranchuFranchu
force-pushed
the
chore/sc-484/optimize-pre-reduce-pass
branch
2 times, most recently
from
660dbf1 to
13d5636
Compare
tjjfvi
reviewed
Mar 4, 2024
tjjfvi
approved these changes
Mar 5, 2024
FranchuFranchu
force-pushed
the
chore/sc-484/optimize-pre-reduce-pass
branch
3 times, most recently
from
4d57125 to
c6872dd
Compare
This is done by visiting each definition from dependency to dependent and reducing them, then overriding the `Def` in the host with the pre-reduced verison. This avoids repeated work. Add tests for pre-reduce.
Don't take into account rwts.dref in pre reduce until #73 is merged.
Co-authored-by: T6 <[email protected]>
FranchuFranchu
force-pushed
the
chore/sc-484/optimize-pre-reduce-pass
branch
from
258d383 to
d73b2ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by visiting each definition from dependency to dependent and reducing them, then overriding the
Defin the host with the pre-reduced verison. This avoids repeated work.Also added tests for the pre-reduction pass.