Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-480] Fix ast parsing stack overflows in hvm-core by using the stacker crate. #75

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

FranchuFranchu
Copy link
Contributor

No description provided.

Copy link

This pull request has been linked to Shortcut Story #480: Fix AST parsing stack overflows on hvm-core.

src/ast.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you rebased main into this branch, instead of this branch onto main?

src/util/stack.rs Outdated Show resolved Hide resolved
src/util/stack.rs Outdated Show resolved Hide resolved
src/util/stack.rs Outdated Show resolved Hide resolved
@FranchuFranchu FranchuFranchu force-pushed the bug/sc-480/fix-ast-parsing-stack-overflows-on-hvm-core branch 2 times, most recently from 741ebe5 to 28f8b1e Compare March 4, 2024 13:49
Copy link
Contributor

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe_grow needs to be added to the file list in main

@tjjfvi tjjfvi force-pushed the bug/sc-480/fix-ast-parsing-stack-overflows-on-hvm-core branch from dc5bc04 to 85f6765 Compare March 4, 2024 14:56
@tjjfvi tjjfvi enabled auto-merge March 4, 2024 14:58
@tjjfvi tjjfvi added this pull request to the merge queue Mar 4, 2024
Merged via the queue into main with commit 2867cb7 Mar 4, 2024
5 checks passed
@tjjfvi tjjfvi deleted the bug/sc-480/fix-ast-parsing-stack-overflows-on-hvm-core branch March 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants