refactor: split/reorganize files #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranchuFranchu
suggested changes
Feb 29, 2024
src/run/allocator.rs
Outdated
|
|
||
| impl Heap { | ||
| /// Allocate an area for the net's heap with a given size. | ||
| pub fn new(size: usize) -> Box<Heap> { |
There was a problem hiding this comment.
Removing Net::init_heap is a backwards-incompatible change; we are going to have to coordinate with the lang team, because I'm pretty sure they use it somewhere.
There was a problem hiding this comment.
Yeah, there are a few breaking changes to the API here.
Now that the circular dependency is removed, I don't think it needs to be coördinated very much; they can simply update hvm-core once they're ready.
Merged
FranchuFranchu
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks up the monolithic files for easier navigation.