-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sc-463] Remove hvm-lang
as a dev-dependency
by making the tests work on hvm-core ASTs only.
#65
Merged
FranchuFranchu
merged 12 commits into
main
from
chore/sc-463/refactor-and-reorganize-hvm-core-tests
Feb 27, 2024
Merged
[sc-463] Remove hvm-lang
as a dev-dependency
by making the tests work on hvm-core ASTs only.
#65
FranchuFranchu
merged 12 commits into
main
from
chore/sc-463/refactor-and-reorganize-hvm-core-tests
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on hvm-core ASTs only. Compilation to .hvmc is done *before* the tests, by the `tests/compile_files.sh` script. Add a `Net::with_argument` function that passes an argument to a net.
This pull request has been linked to Shortcut Story #463: Refactor and reorganize hvm-core tests. |
tjjfvi
reviewed
Feb 26, 2024
FranchuFranchu
force-pushed
the
chore/sc-463/refactor-and-reorganize-hvm-core-tests
branch
2 times, most recently
from
February 27, 2024 12:43
adfc9f8
to
36ef219
Compare
tjjfvi
reviewed
Feb 27, 2024
FranchuFranchu
force-pushed
the
chore/sc-463/refactor-and-reorganize-hvm-core-tests
branch
from
February 27, 2024 14:25
6f31a39
to
13971ec
Compare
tjjfvi
approved these changes
Feb 27, 2024
FranchuFranchu
deleted the
chore/sc-463/refactor-and-reorganize-hvm-core-tests
branch
February 27, 2024 18:22
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation to
.hvmc
is done before the tests, by thetests/compile_files.sh
script.Add a
Net::with_argument
function that passes an argument to a net.