-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dylib compilation and runtime loading #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tjjfvi
reviewed
Apr 25, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tjjfvi
reviewed
Apr 29, 2024
This comment has been minimized.
This comment has been minimized.
tjjfvi
approved these changes
May 2, 2024
Perf run for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112.
--dylib
to thecompile
command. Per The Rust Reference, this will output a "*.so
file on Linux,*.dylib
file on macOS, and*.dll
file on Window."--include
to therun
command. A space-delimited list of hvm-core dynamic library files to load before running the provided hvm-core file.Additionally cleans up some
clap
args:String
toPathBuf
.short
andlong
attributes if they are identical to the implicit ones.Example:
two-and-three.hvmc
:two-plus-three.hvmc
:Compiling and running:
Notes
Generated dylibs are versioned with the hvmc crate version that was used to compile them. Using a dylib with a version of hvmc that does not match the dylib produces a warning like the following: