-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify compilation strategy to allow for io defs #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reorganizes the compilation source so that user-defined defs and stdlib defs are all in the same map, so they can be treated equally when compiling instructions. empty defs are created and hoisted to the top of `insert_into_host` to allow for mutually recursive definitions.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tjjfvi
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it'd make the codegen code cleaner at all to have something like
struct DefInfo<'h> {
rust_name: String,
def: &'h InterpretedDef,
refs: BTreeSet<&'h str>,
}
and create a defs: BTreeMap<&'h str, DefInfo<'h>>
at the beginning instead of the iterator
This comment has been minimized.
This comment has been minimized.
tjjfvi
reviewed
Apr 19, 2024
Perf run for
|
tjjfvi
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #111.
Reorganizes the compilation source so that user-defined defs and stdlib defs are all in the same map, so they can be treated equally when compiling instructions.
Empty defs are created and hoisted to the top of
insert_into_host
to allow for mutually recursive definitions.Compiled source looks like this: