Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output list of non-normalized defs after pre-reduce #115

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Output list of non-normalized defs after pre-reduce #115

merged 3 commits into from
Apr 5, 2024

Conversation

developedby
Copy link
Member

No description provided.

@developedby developedby requested review from tjjfvi and imaqtkatt April 4, 2024 18:20
@HigherOrderBot

This comment has been minimized.

Sign in to view
@developedby developedby mentioned this pull request Apr 4, 2024
Merged
tjjfvi
tjjfvi reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@tjjfvi tjjfvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the version, too, since the api of Net::reduce changed?

src/run/net.rs Outdated Show resolved Hide resolved
src/transform/pre_reduce.rs Outdated Show resolved Hide resolved
@developedby developedby requested a review from tjjfvi April 4, 2024 19:41
@HigherOrderBot
Copy link
Collaborator

Perf run for 2ca22cb:

file              mode        main          2ca22cbee36e
========================================================
sum_rec           intr-singl      14.191 s      13.964 s
                  intr-multi       7.231 s       7.495 s
--------------------------------------------------------
bitonic_sort_lam  intr-singl      11.113 s      11.243 s
                  intr-multi       5.550 s       5.615 s
--------------------------------------------------------
merge_sort        intr-singl       7.130 s       7.356 s
                  intr-multi       3.650 s       3.743 s
--------------------------------------------------------
sum_tail          intr-singl       1.187 s       1.145 s
                  intr-multi       1.153 s       1.149 s
--------------------------------------------------------
c2                intr-singl       0.000 s       0.000 s
                  intr-multi       0.001 s       0.001 s
--------------------------------------------------------
sum_tree          intr-singl       9.017 s       9.076 s
                  intr-multi       4.336 s       4.543 s
--------------------------------------------------------
boom              intr-singl       2.258 s       2.270 s
                  intr-multi       2.528 s       2.502 s
--------------------------------------------------------
radix_sort_lam    intr-singl       9.348 s       9.547 s
                  intr-multi       4.703 s       4.831 s

@developedby developedby added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 503a548 Apr 5, 2024
5 checks passed
@developedby developedby deleted the non-normal-pre-reduce branch April 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imaqtkatt imaqtkatt imaqtkatt approved these changes

@tjjfvi tjjfvi tjjfvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@developedby @HigherOrderBot @tjjfvi @imaqtkatt