Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IO/FS/read_line when the line ends with a EOF #700

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

LunaAmora
Copy link
Contributor

No description provided.

@LunaAmora LunaAmora self-assigned this Aug 29, 2024
@LunaAmora LunaAmora force-pushed the 638-read-line-eof-bug branch from 74bd796 to 9a0d42b Compare August 29, 2024 12:07
@LunaAmora LunaAmora linked an issue Aug 29, 2024 that may be closed by this pull request
@LunaAmora LunaAmora changed the title #638 Fix IO/FS/read_line when the line ends with a EOF Fix IO/FS/read_line when the line ends with a EOF Aug 29, 2024
@LunaAmora LunaAmora requested a review from developedby August 29, 2024 12:56
@LunaAmora LunaAmora marked this pull request as ready for review August 29, 2024 12:56
Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog

src/fun/builtins.bend Show resolved Hide resolved
@LunaAmora LunaAmora requested a review from developedby August 29, 2024 14:06
src/fun/builtins.bend Outdated Show resolved Hide resolved
src/fun/builtins.bend Outdated Show resolved Hide resolved
@LunaAmora LunaAmora force-pushed the 638-read-line-eof-bug branch from 4f4f450 to 17e3cfe Compare August 29, 2024 14:15
@kings177 kings177 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 0945efc Aug 29, 2024
5 checks passed
@developedby developedby deleted the 638-read-line-eof-bug branch August 29, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IO/FS/read_line never ends when reading last line with bend run-c
3 participants