Implement remaining hvm1 builtins.
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #509: Implement remaining hvm1 builtins in hvm2. |
developedby
requested changes
Mar 13, 2024
|
We got read/write from files and read/write from stdio. I think that's enough for most simple uses. |
FranchuFranchu
force-pushed
the
feature/sc-509/implement-hvm1-builtins
branch
from
1499cb7 to
e6b456f
Compare
developedby
approved these changes
Mar 15, 2024
FranchuFranchu
force-pushed
the
feature/sc-509/implement-hvm1-builtins
branch
from
c118c24 to
4572062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote implementations for
HVM.query,HVM.store, andHVM.loadusing a new API for defs that exists in a hvm-core branch. I'm creating a PR mostly to get feedback on whether the API is high-level and practical enough forhvm-lang.If it isn't, we can postpone this until we have an API in
hvm-corethat's higher-level. (it'd likely end up looking likerlua's API, with lifetimedPorts which would allow us to make it completely safe).