Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NunitXml.TestLogger from 4.1.0 to 5.0.0 #2098

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Bump NunitXml.TestLogger from 4.1.0 to 5.0.0 #2098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bd2942
Bump NunitXml.TestLogger from 4.1.0 to 5.0.0
dependabot[bot] Dec 23, 2024
a8b7070
Remove disused test loggers
Dec 30, 2024
29b8a03
Merge branch 'develop' into dependabot/nuget/develop/NunitXml.TestLog…
JFriel Jan 6, 2025
8b1fc76
Remove old TestLogger ref from docs
Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,10 @@
<PackageVersion Include="System.Resources.Extensions" Version="9.0.0" />
<PackageVersion Include="VPKSoft.ScintillaLexers.NET" Version="1.1.16" />
<PackageVersion Include="HIC.System.Windows.Forms.DataVisualization" Version="1.0.1" />
<PackageVersion Include="NunitXml.TestLogger" Version="4.1.0" />
<PackageVersion Include="NUnit3TestAdapter" Version="4.6.0" />
<PackageVersion Include="NUnit.Analyzers" Version="4.5.0" />
<PackageVersion Include="NSubstitute" Version="5.3.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageVersion Include="coverlet.collector" Version="6.0.3" />
</ItemGroup>
</Project>
</Project>
38 changes: 18 additions & 20 deletions Documentation/CodeTutorials/PluginWriting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,6 @@ dotnet add package HIC.RDMP.Plugin.Test
dotnet add package Microsoft.NET.Test.Sdk
dotnet add package NUnit
dotnet add package NUnit3TestAdapter
dotnet add package NunitXml.TestLogger
```

Add the following test:
Expand All @@ -516,27 +515,26 @@ using Rdmp.Core.DataFlowPipeline;
using ReusableLibraryCode.Progress;
using System.Data;

namespace MyPipelinePluginTests
namespace MyPipelinePluginTests;

public class TestAnonymisationPlugins
{
public class TestAnonymisationPlugins
[Test]
public void TestBasicDataTableAnonymiser1()
{
[Test]
public void TestBasicDataTableAnonymiser1()
{
var dt = new DataTable();
dt.Columns.Add("Story");
dt.Rows.Add(new[] {"Thomas went to school regularly"});
dt.Rows.Add(new[] {"It seems like Wallace went less regularly"});
dt.Rows.Add(new[] {"Mr Smitty was the teacher"});

var a = new BasicDataTableAnonymiser1();
var resultTable = a.ProcessPipelineData(dt,new ThrowImmediatelyDataLoadEventListener(),new GracefulCancellationToken());

Assert.AreEqual(resultTable.Rows.Count,3);
Assert.AreEqual("REDACTED went to school regularly",resultTable.Rows[0][0]);
Assert.AreEqual("It seems like REDACTED went less regularly",resultTable.Rows[1][0]);
Assert.AreEqual("Mr Smitty was the teacher",resultTable.Rows[2][0]);
}
using var dt = new DataTable();
dt.Columns.Add("Story");
dt.Rows.Add(new[] {"Thomas went to school regularly"});
dt.Rows.Add(new[] {"It seems like Wallace went less regularly"});
dt.Rows.Add(new[] {"Mr Smitty was the teacher"});

var a = new BasicDataTableAnonymiser1();
var resultTable = a.ProcessPipelineData(dt,new ThrowImmediatelyDataLoadEventListener(),new GracefulCancellationToken());

Assert.AreEqual(resultTable.Rows.Count,3);
Assert.AreEqual("REDACTED went to school regularly",resultTable.Rows[0][0]);
Assert.AreEqual("It seems like REDACTED went less regularly",resultTable.Rows[1][0]);
Assert.AreEqual("Mr Smitty was the teacher",resultTable.Rows[2][0]);
}
}

Expand Down
1 change: 0 additions & 1 deletion Rdmp.Core.Tests/Rdmp.Core.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="NunitXml.TestLogger" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Rdmp.Core\Rdmp.Core.csproj" />
Expand Down
1 change: 0 additions & 1 deletion Rdmp.UI.Tests/Rdmp.UI.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="NunitXml.TestLogger" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Application\ResearchDataManagementPlatform\ResearchDataManagementPlatform.csproj" />
Expand Down
Loading