Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some codeql/inspection code issues #2087

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Dec 9, 2024

Fix up some .Dispose/using issues, make finding most recent load ID more efficient

Proposed Change

  • Fix up some missed using opportunities and duplicate .Dispose() calls, also inefficient LINQ invocations

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

Fix up some .Dispose/using issues, make finding most recent load ID more efficient
@jas88 jas88 marked this pull request as draft December 9, 2024 16:02
Add Hashcode, Equals methods.
Tweak equality semantics for RDMP DB oddities
@jas88 jas88 marked this pull request as ready for review December 13, 2024 17:26
@jas88 jas88 requested a review from JFriel December 13, 2024 17:26
@jas88 jas88 enabled auto-merge (squash) December 13, 2024 17:26
@jas88 jas88 merged commit d420131 into develop Dec 20, 2024
6 checks passed
@jas88 jas88 deleted the feature/overviewmodelfix branch December 20, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants