Feature/rdmp 73 holdouts extractions #1648
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+71
to
+74
| catch (Exception) | ||
| { | ||
| dateCell = DateTime.Parse(row.Field<string>(dateColumn), CultureInfo.InvariantCulture); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
JFriel
changed the title
| if (!string.IsNullOrWhiteSpace(whereCondition)) | ||
| { | ||
| DataTable dt = toProcess.Clone(); | ||
| DataTable dt2 = new(); |
Check warning
Code scanning / CodeQL
Missing Dispose call on local IDisposable Warning
| if (!string.IsNullOrWhiteSpace(whereCondition)) | ||
| { | ||
| DataTable dt = toProcess.Clone(); | ||
| DataTable dt2 = new(); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the extraction half of the holdout piece.
Allows for holdouts to be generated at extraction time and be stored in an arbitrary file.
Holdouts can be a set number, a percentage, can optionally require to be between two dates and can be further filtered