Add configurable timeout value #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…access when bot request takes too long.
CodeNinja-Z
commented
Mar 2, 2023
lib/prerender_rails.rb
Outdated
| if @options[:read_timeout] | ||
| error_type = '503 Service Unavailable' | ||
| error_msg = "ERROR: timed out while trying to connect. #{e.message}" | ||
| raise Timeout::Error.new(error_type), error_msg |
There was a problem hiding this comment.
We only need to catch the timeout exception to solve our issue. So I added the rescue specifically for timeout if the read_timeout option is provided. Otherwise, just follow what it was, ie. catch the StandardError but not do anything.
I'm not sure what format of the error data we should return to the crawlers bot, maybe JSON? I looked up but didn't find useful resources. So just return the Rails standard format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new configurable argument
read_timeoutto the options hash to prevent bot requests from taking too long and constantly occupying server threads, which could cause a slow response alert on our end.JIRA issue: https://himama.atlassian.net/browse/FLRS-790