Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh refinement: multiple Poisson solvers #527

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented Jun 12, 2021

This PR adds multiple Poisson solvers, one for each level of MR.

Since all of the member variables are different on each level, the m_poisson_solver is now a vector over levels.
Additionally, previously only a single geometry was handed to the Fields::AllocData function, now it is a vector of over levels and the correct geometry is used.

This PR was tested by printing the dx in the creation of the Poisson solver, so each level indeed generates the correct arrays.

This PR is based on #526.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the component: fields About 3D fields and slices, field solvers etc. label Jun 12, 2021
@SeverinDiederichs SeverinDiederichs merged commit cafc744 into Hi-PACE:development Jun 14, 2021
@SeverinDiederichs SeverinDiederichs deleted the mr_multiple_staging_areas branch June 14, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: fields About 3D fields and slices, field solvers etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants