[HZUNITY-16] Default placements #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnunogarcia
force-pushed
the
HZUNITY-16-Default-placements
branch
from
12a8066 to
ee7cab8
Compare
jjnunogarcia
force-pushed
the
HZUNITY-16-Default-placements
branch
from
ee7cab8 to
b4e9c4c
Compare
dmvicente
reviewed
Jun 11, 2018
| <uses-permission android:name="android.permission.INTERNET" /> | ||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" /> | ||
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> | ||
| <uses-sdk android:minSdkVersion="14" /> |
There was a problem hiding this comment.
Was this changed on the Heyzap side?
Assets/Scripts/AdManager.cs
Outdated
| @@ -18,9 +17,10 @@ public class AdManager : MonoBehaviour { | |||
| [SerializeField] | |||
| private Toggle offerwallCloseOnFirstClickToggle; | |||
| [SerializeField] | |||
| private Text offerwallCurrencyIdTextField; | |||
| private readonly Text offerwallCurrencyIdTextField; | |||
There was a problem hiding this comment.
Why this change? Does this not affect the setting of the currency id on the testapp?
There was a problem hiding this comment.
I am not sure. I could remove it and we would be safer, if that's fine.
There was a problem hiding this comment.
Did you test it? If so, then we're good. Otherwise I wouldn't change it
| this.console.MustNotBeNull(); | ||
| void Awake() | ||
| { | ||
| UnityEngine.Assertions.Assert.IsNotNull(adTagTextField); |
There was a problem hiding this comment.
The old assertion was deprecated.
|
|
||
| [SerializeField] | ||
| private AdManager adManager; | ||
| private readonly AdManager adManager; |
There was a problem hiding this comment.
Same as above: any reason why this was changed?
dmvicente
approved these changes
Jun 11, 2018
dmvicente
approved these changes
Jun 11, 2018
# Conflicts: # Assets/Plugins/Android/Heyzap/AndroidManifest.xml # Assets/Plugins/Heyzap/HeyzapAds.cs # Assets/Scripts/AdManager.cs # ProjectSettings/GraphicsSettings.asset # ProjectSettings/ProjectSettings.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.