Code

Improve code quality#51

Code

Open

HeyPouya wants to merge 100 commits intomasterHeyPouya/AndroidAppUpdater:masterfrom refactor/improve-code-qualityHeyPouya/AndroidAppUpdater:refactor/improve-code-qualityCopy head branch name to clipboard

+4,287-2,602

Commits

Commits on Jan 5, 2024

• Removed the redundant when condition

  

  Pouya Heydari

  committed
  6b870f8

• Added EMPTY state to the dialog

  

  Pouya Heydari

  committed
  40f527a

• Fixed dialog getting dismissed after configuration changed in the demo app

  

  Pouya Heydari

  committed
  d74edee

• Disabled some ktlint rules after upgrading to the latest version

  

  Pouya Heydari

  committed
  235baa5

• Added app theme to all compose preview functions

  

  Pouya Heydari

  committed
  d70340d

• Added DialogHeaderModel

  

  Pouya Heydari

  committed
  de7b029

Commits on Jan 7, 2024

• Used ViewModelFactory to inject dependencies into the ViewModel

  

  Pouya Heydari

  committed
  92cae5d

Commits on Jan 10, 2024

• migrated compose module to MVI structure

  

  Pouya Heydari

  committed
  3025628

• hoisted onStoreClickListener and onDirectLinkClickListener

  

  Pouya Heydari

  committed
  9adf190

• Removed usages of StoreListItem in inner compose components

  

  Pouya Heydari

  committed
  09048ce

Commits on Jan 11, 2024

• Moved DialogStates to appupdater module

  

  Pouya Heydari

  committed
  c01dd6a

Commits on Jan 13, 2024

• Used Composition for AppStores and moved the app store object creation into the core module

  

  Pouya Heydari

  committed
  318d688

Commits on Jan 14, 2024

• Moved intent creation to a builder

  

  Pouya Heydari

  committed
  4b8ff12

• improved intent builder

  

  Pouya Heydari

  committed
  1c8fa40

• Added mockito dependency

  

  Pouya Heydari

  committed
  1a7b16c

Commits on Feb 5, 2024

• Upgraded dependencies

  

  Pouya Heydari

  committed
  52d27a4

• Changed object creation to kotlin reflect

  

  Pouya Heydari

  committed
  1df43ce

• Added StoreIntentProviderTest.kt

  

  Pouya Heydari

  committed
  33fd03d

Commits on Mar 2, 2024

• Separated store and directdownload modules

  

  Pouya Heydari

  committed
  15cb059

Commits on Mar 17, 2024

• Divided direct download and store list items into 2 different properties to separate concerns

  

  Pouya Heydari

  committed
  ec00a11

Commits on Apr 10, 2024

• Added error callback when opening a store encounters error

  

  Pouya Heydari

  committed
  cd0dbdd

Commits on Apr 11, 2024

• Removed redundant comments

  

  Pouya Heydari

  committed
  2f77375

• Updated stores test according to new changes

  

  Pouya Heydari

  committed
  8605055

• Moved stores to domain package

  

  Pouya Heydari

  committed
  2f3bad4

• Fixed packaging in androidTest according to the source packaging

  

  Pouya Heydari

  committed
  acf338e

• Added tests for StoreFactory

  

  Pouya Heydari

  committed
  049cc8a

• Added tests for StoreManager

  

  Pouya Heydari

  committed
  1741608

• Updated agp version

  

  Pouya Heydari

  committed
  e2eaec3

• Updated mockito version

  

  Pouya Heydari

  committed
  3bbd5e7

• Updated agp version

  

  Pouya Heydari

  committed
  d61902e

• Updated coroutines version

  

  Pouya Heydari

  committed
  f6832d0

• Updated compose and kotlin version

  

  Pouya Heydari

  committed
  48f2756

• Removed kotlin reflect dependency

  

  Pouya Heydari

  committed
  f476601

• Updated mockito kotlin version

  

  Pouya Heydari

  committed
  dd15a1b

Commits on Apr 15, 2024

• Moved utils package inside ui package

  

  Pouya Heydari

  committed
  9109521

• Updated compose previews

  

  Pouya Heydari

  committed
  38219cb

• Added UI test for DividerComponent

  

  Pouya Heydari

  committed
  1c8f1c9

• Upgraded min sdk version to 23

  

  Pouya Heydari

  committed
  63729e2

• Removed redundant manifest files

  

  Pouya Heydari

  committed
  8798ef3

• Added ui test for DirectDownloadLinkComponent

  

  Pouya Heydari

  committed
  0757974

• Added padding to store list items

  

  Pouya Heydari

  committed
  38c74a6

• Added a 80dp fixed size for store images and max 1 lines with ellipsis

  

  Pouya Heydari

  committed
  89b7947

• Replaced myket png image with svg

  

  Pouya Heydari

  committed
  970c8aa

• Changed image size to 64dp

  

  Pouya Heydari

  committed
  90dc9a7

• Replaced google play png image with svg

  

  Pouya Heydari

  committed
  c05f067

• Fixed lenovo app center icon in the preview

  

  Pouya Heydari

  committed
  b7c3280

• Replaced Huawei app gallery png image with svg

  

  Pouya Heydari

  committed
  ba0353d

• Replaced aptoide png image with svg

  

  Pouya Heydari

  committed
  495b527

• Changed ImageView size to 64dp fixed size

  

  Pouya Heydari

  committed
  59d0ed9

Commits on Apr 16, 2024

• Added Ui tests for SquareStoreItemComponent

  

  Pouya Heydari

  committed
  e7b2112

• Added assertTextEqual to the test

  

  Pouya Heydari

  committed
  fb57503

• Added @PreviewLightDark to previews

  

  Pouya Heydari

  committed
  be73299

• Added roboelectric and moved compose component tests to test package

  

  Pouya Heydari

  committed
  096e55d

• Made Divider text available to set by other components

  

  Pouya Heydari

  committed
  ed80e32

• Made classes internal

  

  Pouya Heydari

  committed
  61cd954

• Converted including android resources into a single line

  

  Pouya Heydari

  committed
  869191b

• Changed running tests on ci to testDebugUnitTest

  

  Pouya Heydari

  committed
  11c840e

• Made dialog title and description available to be set from higher level components

  

  Pouya Heydari

  committed
  06161d0

• Added unit tests for UpdateInProgressDialogComponent

  

  Pouya Heydari

  committed
  09f3369

• Added typeface to DialogHeaderComponent and extracted the icon to be set by higher level components

  

  Pouya Heydari

  committed
  cbf6073

• Added typeface to components

  

  Pouya Heydari

  committed
  205384e

• Added unit tests for DialogHeaderComponent

  

  Pouya Heydari

  committed
  883d2d5

• Added @PreviewLightDark

  

  Pouya Heydari

  committed
  780fc15

• Removed throwing exception

  

  Pouya Heydari

  committed
  b1a10c6

Commits on Apr 21, 2024

• Upgraded dependencies

  

  Pouya Heydari

  committed
  caccac4

• Started using version catalog for plugin dependencies

  

  Pouya Heydari

  committed
  840a204

• Renamed AppUpdaterDialog to AppUpdaterDialogComponent

  

  Pouya Heydari

  committed
  a8c5843

• Moved out the divider text to be set by the user explicitly

  

  Pouya Heydari

  committed
  866b6b4

Commits on Apr 23, 2024

• Added tests for AppUpdaterDialogComponent

  

  Pouya Heydari

  committed
  b7b3b09

• added viewModel as compose function's argument to be able to inject a mock

  

  Pouya Heydari

  committed
  56a8aa8

Commits on Apr 25, 2024

• Started using TYPESAFE_PROJECT_ACCESSORS in gradle files

  

  Pouya Heydari

  committed
  d013fd3

• Changed core module to a pure kotlin library

  

  Pouya Heydari

  committed
  9f0e95f

• Changed build to assemble in jitpack.yml to prevent running roboelectric tests while deploying the library on jitpack env

  

  Pouya Heydari

  committed
  8a6f16a

• Removed sealed to prevent this error while deploying the library: PermittedSubclasses requires ASM9

  

  Pouya Heydari

  committed
  d98ad68

• Used constants for the kotlin java version compatibility

  

  Pouya Heydari

  committed
  2eae69c

• Added store and directdownload modules to jitpack.yml

  

  Pouya Heydari

  committed
  1db4eae

Commits on May 23, 2024

• Upgraded all dependencies including Kotlin to version 2.0

  

  Pouya Heydari

  committed
  fd78d2e

Commits on Jun 10, 2024

• Moved handling errors while opening a store from core to higher level modules

  

  Pouya Heydari

  committed
  9074215

• Fixed unit test

  

  Pouya Heydari

  committed
  a60dfc4

• Moved StoreIntentBuilderTest too unit test package

  

  Pouya Heydari

  committed
  00bf819

Commits on Jul 11, 2024

• Upgraded dependencies to the latest version

  HeyPouya

  committed
  14b8d15

• Removed passing viewModel into the AndroidAppUpdater compose function to make the code more readable

  HeyPouya

  committed
  50dc950

Commits on Jul 12, 2024

• Upgraded dependencies

  HeyPouya

  committed
  601abc4

• Added maven publish gradle dependency and added usage for core

  HeyPouya

  committed
  d30c344

• Removed publish to maven for core

  HeyPouya

  committed
  530ed0c

• Added maven publish gradle plugin to compose module

  HeyPouya

  committed
  0ff39e9

• Added maven publish gradle plugin to main module

  HeyPouya

  committed
  a601109

• Added maven publish gradle plugin to directdownload module

  HeyPouya

  committed
  d8449e7

• Added maven publish gradle plugin to store module

  HeyPouya

  committed
  69c829d

Commits on Jul 29, 2024

• Upgraded dependencies

  HeyPouya

  committed
  b2b3dd6

• Added tests for AndroidAppUpdaterScreen

  HeyPouya

  committed
  f258e17

Commits on Oct 8, 2024

• Upgraded dependencies

  HeyPouya

  committed
  859240c

Commits on Nov 15, 2024

• Fixed an issue with the direct download which was not showing the progress dialog after the first apk download

  HeyPouya

  committed
  52d01c7

• Upgraded dependencies and added support for sdk v35

  HeyPouya

  committed
  ae55870

Commits on Dec 6, 2024

• Cleaned up appupdater module

  HeyPouya

  committed
  dfa5c9e

• Upgraded dependencies to the latest version

  HeyPouya

  committed
  c52d157

Commits on Dec 27, 2024

• Moved colors out of directdownload package and changed domain layer to not depend on data

  HeyPouya

  committed
  a2ab464

Commits on Dec 29, 2024

• Added unit tests for usecases and repository in directdownload module

  HeyPouya

  committed
  a1d1e7f

• Upgraded dependency versions

  HeyPouya

  committed
  9503411

• Refactored directdownload to return download state instead of a plain boolean to indicate if the download is in progress or not

  HeyPouya

  committed
  bb9b396