Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at adding types to functions and methods. #44

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

distortedsignal
Copy link
Contributor

Developer Certificate of Origin Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 660 York Street, Suite 102, San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Signed-off-by: Tom Kelley [email protected]

@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #44 into master will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   91.01%   91.19%   +0.17%     
==========================================
  Files           2        2              
  Lines         345      352       +7     
==========================================
+ Hits          314      321       +7     
  Misses         31       31
Impacted Files Coverage Δ
samlauthenticator/samlauthenticator.py 91.16% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78b663...7273d55. Read the comment docs.

@distortedsignal
Copy link
Contributor Author

While they didn't request it, I want to thank freenode user SnoopJeDi for helping me figure out that, whenever the multiple returns pattern in python is used, python is, in fact, returning a tuple. It was supremely swell of them.

@distortedsignal distortedsignal linked an issue Feb 28, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type annotations to function calls
2 participants