-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds spire-1.1.1 helm charts #27
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandre Alvino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left some nits and considerations
@@ -0,0 +1,6 @@ | |||
apiVersion: v2 | |||
appVersion: 1.16.0 | |||
description: A Helm chart for Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if this have already been updated in the newer PR's, but if not, we should properly describe the chart
|
||
{{/* | ||
Create a default fully qualified app name. | ||
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if there aren't any bugs that can happen if something gets tweaked?
agent.conf: | | ||
agent { | ||
data_dir = "/run/spire" | ||
log_level = "DEBUG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider parametarizing log level for SPIRE apps
socket_path = "{{ .Values.configmaps.serverConfig.socketPath }}" | ||
trust_domain = "{{ .Values.configmaps.serverConfig.trustDomain }}" | ||
data_dir = "/run/spire/server/data" | ||
log_level = "DEBUG" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider parametarizing log level for SPIRE apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙆♂️
Adds SPIRE 1.1.1 helm charts.
The helm charts include deployments for SPIRE Server along with the new
controller-manager
, SPIRE Agent + CSI Driver configured to integrate with Istio through SDS.Signed-off-by: Alexandre Alvino [email protected]