Adds mithrilctl initial implementation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Alvino <[email protected]>
alexandrealvino
requested review from
maxlambrecht,
mchurichi,
wibarre,
jufantozzi,
n-th and
mgbcaio
Signed-off-by: Alexandre Alvino <[email protected]>
Signed-off-by: Alexandre Alvino <[email protected]>
n-th
reviewed
Jul 26, 2022
| failureFormat := " \033[31mx\x1b[0m %s\n" | ||
|
|
||
| if err != nil { | ||
| fmt.Fprintf(spinner.Writer, failureFormat, "Deploying SPIRE 🗝️") |
There was a problem hiding this comment.
If we get an error, why does it print "Deploying SPIRE"?
n-th
approved these changes
Jul 26, 2022
Comment on lines
+18
to
+19
| spiref, _ := cmd.Flags().GetBool("spire") | ||
| istiof, _ := cmd.Flags().GetBool("istio") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds initial implementation of
mithrilctl.mithrilctlfeatures:Jira task
Depends on PR#25
Signed-off-by: Alexandre Alvino [email protected]