Update Ember #6
Closed
Update Ember #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HeroicEric I updated this. I can't figure out why #7 still has randomly failing phantom tests (my phantom won't even load tests locally at the moment), but all the tests are green on chrome. What's your feeling about getting some of this wrapped up? |
|
+1 please, this fixes a deprecation |
|
@donaldwasserman @HeroicEric Any update on this? This library is causing a deprecation warning unfortunately |
|
@crhayes I'll make some time for this today. Thank you for pinging me! 😄 |
|
@HeroicEric Thanks for the quick response, appreciate it! |
|
Hello - I was using this for a specific work project and somewhat forgot the details (we were using a private fork IIRC)
I'd be happy to revisit this if need be and go back and get off my private fork.
…On Dec 10, 2018, 2:45 PM -0500, Chris Hayes ***@***.***>, wrote:
@HeroicEric Thanks for the quick response, appreciate it!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@donaldwasserman thanks for the help! Sorry for not following up sooner. I updated to a newer version of ember and ember-cli here #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ember packages to 2.18
I closed #5 in lieu of this and make a subsequent PR with the additional functionality @HeroicEric