fix: added error checks on account routes #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure error mentioned in other fixes is general or specific to me (used chrome browser). |
|
I am working on this code duplication issue in SonarCloud Quality Gate test. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thank you. I will look into this PR as soon as I have some spare time :) |
|
It would be great if you could review this before Hacktoberfest ends. |
bjarneo
approved these changes
Oct 31, 2023
bjarneo
pushed a commit
that referenced
this pull request
Jun 8, 2024
* fix: added error checks on account routes * added ErrorBox and SuccessBox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #211
: added loader on every route like /account
: added success notification on some routes
: added specific notification message upon deletion success
: added extra checks for routes
: added more descriptive variable names
: added redirect to /signout upon account deletion
: added general timeout of 2.5s on success notification
: other fixes
-- : error: isLoggedIn: true was dispatched due to delay in clearing cookie & calling getCookie() in useEffect() of Header
-- : fix: added await for async call of signOut() in useEffect() of SignOut component