Wrap for shp2msh and msh2vtu #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Can you add a macros file with version tokens like here
galaxy-tools/tools/omero/macros.xml
Line 3 in c78bd5e
In order to use them, just import in the tools:
Can be used in the tool tag and for the requirement.
rmassei
reviewed
Nov 28, 2024
rmassei
reviewed
Nov 28, 2024
rmassei
reviewed
Nov 28, 2024
rmassei
reviewed
Nov 28, 2024
rmassei
reviewed
Nov 28, 2024
rmassei
reviewed
Nov 28, 2024
rmassei
reviewed
Nov 28, 2024
|
@tStehling please start a new PR for the last commit. To finish this one, just respond / fix according to the comments of @rmassei . |
tools/ogstools/Converter/macros.xml
Outdated
| @@ -0,0 +1,18 @@ | |||
| <macros> | |||
| <!-- for historic reasons the omero-py version is used as the version for all tools --> | |||
There was a problem hiding this comment.
Suggested change
| <!-- for historic reasons the omero-py version is used as the version for all tools --> |
tools/ogstools/Converter/macros.xml
Outdated
| <macros> | ||
| <!-- for historic reasons the omero-py version is used as the version for all tools --> | ||
| <token name="@TOOL_VERSION@">0.4.0</token> | ||
| <token name="@PROFILE@">21.05</token> |
There was a problem hiding this comment.
Suggested change
| <token name="@PROFILE@">21.05</token> | |
| <token name="@PROFILE@">23.0</token> |
| long_description: | | ||
| A suite of tools for ogs. | ||
| categories: | ||
| - Ecology |
There was a problem hiding this comment.
We need to find a fitting category. I'm going to ask Lars.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.