Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with the develop #24

Open
wants to merge 231 commits into
base: soil_color
Choose a base branch
from

Conversation

HelinWei-NOAA
Copy link
Owner

Description

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

ChunxiZhang-NOAA and others added 30 commits December 2, 2022 10:37
* Change fv3atm branch to bugfix/noahmp_tq2m

Co-authored-by: jkbk2004 <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
…ototype 8, and turn on prognostic closure. (#1480)

* Generation of gfsv17 tests for RT's beyond P8, updates in FV3 and ccpp submodules

* Added DNATS=0 flag to not exclude any tracers from advection

* update TKE contribution from cu for progsigma in deep and shallow cu

* Correct noareo tests to set DNATS=0 to ensure advection of all tracers

* Address review comments - clean out P7 and P8 labels in GFSv17 tests

* update rt.conf removing old control tests, adding a cpld gfsv17 test

* add outerloop wave coupling to a gfsv17 test

* remove duplicate test

Co-authored-by: Jessica Meixner <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
* adding hr_ave_chem_v1

* aqm diag_table changes

Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: JONG KIM <[email protected]>
* removed control_2dwrtdecomp, control_fhzero, control_2threads_debug
* Update Jenkinsfile

* Update ci.test

* add a mixed-mode test

Co-authored-by: zach1221 <[email protected]>
Co-authored-by: JONG KIM <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
* Performance optimization of moving nest.

* Turn on HAFS RTs on WCOSS2 and switch to use the netcdf (instead of
netcdf_parallel) write_grid_component option for HAFS RTs.

* Update submodule FV3, which points to latest UPP develop branch.

* Update submodule FV3, which will only call atmosphere_fill_nest_cpl at the cap
driver time steps (coupling time steps)

* Adding upoff as a namelist parameter

* Update submodule HYCOM after the momentum flux fix for HAFS FV3ATM-HYCOM
coupling.

* Update submodule FV3 and rename HAFS_V0 CCPP physics suites into HAFS_V1.

* Cleanup of CMakefile for moving nest, and added fv_timers namelist option

Co-authored-by: William Ramstrom <[email protected]>
Co-authored-by: Biju Thomas <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
… indices. (#1497)

* fv3 surface restart io: turn some calls into loops

* turn many loops into subroutine calls, and remove nt_save

* Refactor surface restart logic in FV3GFS_io.F90 to not use hard-coded indices

Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
* Enhanced stability of drag_suite module and added diagnostics

* Added new UGWP diagnostic variables to parm/diag_table/diag_table_rap

* Bug fixes to rap, hrrr and rrfs test description files and tests/parm/rap.nml.IN

* Updated standard_names for do_gsl_drag_ls_bl, do_gsl_drag_ss, do_gsl_drag_tofd and ugwp_seq_update

* Incorporated dustinswales suggestions in ccpp-physics PR#22

* Assumed-shape in gwdps.f

* Added logical flag 'ugwp_seq_update' to gfs_physics_nml namelist

* Modified calculation of dtfac in drag_suite.F90 and revised various long_name's of diagnostic variables

* Removed passage of variables 'ak' and 'bk' to drag_suite -- these are no longer used

* Removed unused variables from GFS_typedefs.F90 and added clarifying comments in ccpp-physics

Co-authored-by: JONG KIM <[email protected]>
* Convert all regression tests to use esmf-managed threading

* update CMakeLists.txt

* update rt.conf

* Comment out unneeded steps in workflows/aux.yml

* turn off control_c384 on cheyenne: all others passed

Co-authored-by: Bin.Li <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
* allow option no updated sub-components

* Run control_c384 and control_c384gdas tests on Gaea using TPN=18

Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
* clean up gitaction yml

* Update build_test.yml, aux.yml
* fix fd_nems.yaml

* cmeps restart will appear as different because field names changes

* set TPN=18 on cheyenne: cpld_control_c192_p8, cpld_restart_c192_p8, hafs_global_multiple_4nests_atm

Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
* MYNNsfc uniform real kind

Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
* Updated FV3 hash, Bring in Fengsha and Pt Source input files, bring in updated aqm.rc

Co-authored-by: Raffaele Montuoro <[email protected]>
…ade (#1554)

* SUPAFAST option sets build flags ideal for HAFS

* add test for HAFS with -DSUPAFAST=ON

* SUPAFAST=>TEST_FASTER_INTEL and add -no-ip to CMAKE_Fortran_FLAGS_RELEASE

* TEST_FASTER_INTEL => FASTER

* Update rt_single function in rt.sh to parse correct .conf file

* Remove fail_test file after model run only if Rocoto is used

* Use -xSSE4.2 on GAEA

* turn off regional_atmaq_debug on gaea: time limit

Co-authored-by: Dusan Jovic <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: JONG KIM <[email protected]>
…dates (#1544)

* Update submodule FV3/upp and use a newer version of g2tmpl/1.10.2.

* Update submodule FV3 and switch to use the unified ugwp scheme for HAFS regression tests.

* Update submodule HYCOM-interface/HYCOM and HYCOM-interface/CMakeLists.txt
so that the debug build options will work properly for the HYCOM subcomponent.

* Update tests/parm/postxconfig-NT-hafs.txt by using FV3/upp/parm/postxconfig-NT-hafs_nosat.txt

* Fixed bug in calculation of nest halo weights identified by Biju Thomas in DDEBUG=ON builds.

Co-authored-by: William Ramstrom <[email protected]>
Co-authored-by: JONG KIM <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
* Remove -xHOST from CICE CMakeLists.txt. #1262

Co-authored-by: [David Huber] <[[email protected]]>
Co-authored-by: JONG KIM <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
* reverting the bug fix for ktherm=2 allows all cpld tests to pass
and the single datm test using ktherm=2 (datm_cdeps_gfs) to also pass
all other datm tests which use ktherm=1 fail

Co-authored-by: JONG KIM <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
…#1566)

* adding regional control back to jenkins-ci (#37)

* Create ESMF field attributes using the same kind as field data values

Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
* AutoRT update for Jenkins.
* Bug fix for cloud effective radius for convective clouds (HR1)
* update CMEPS
* RRTMGP refactoring

* Added RRTMGP p8 coupled RT. Update other GP RTs.

* Adding GP physics blocking to UFS GP RT configurations

* Trim old RRTMGP RTs

* Interface changes for SP build in GP

Co-authored-by: JONG KIM <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
* hpc stack internal location changes and ORT fix

Co-authored-by: JONG KIM <[email protected]>
… (3) hafs bug fix (#1606)

* updates for movingnest debug mode

* add hafs_regional_storm_following_1nest_atm_ocn_debug test

* point MOM6 to test branch

* remove cpld_esmfthreads_p8

Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: JONG KIM <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: zach1221 <[email protected]>
…OAH and NOAH MP LSM, and rename nsradar_reset (#1529)

* Six new winter wx diags, new precip ice density for RUC, NOAH MP and NOAH LSMs, new namelist parameter for nsradar_reset, new flat files for GFS and fv3lam to properly handle new winter wx diags.

* remove six winter wx diags from f00 xml file

* Remove commented out lines related to old computation of precip ice density

* Added 6 winter weather diagnostics + precip ice density (all 2D fields) to select diag_tables

* Use correct postxconfig files

* Include Grant's winter wx mods

Co-authored-by: JONG KIM <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
Co-authored-by: zach1221 <[email protected]>
…ces and turning off output; update FAQ documentation (was 1608); update drag suite intent mods (was 1612) (#1597)

* update cdeps

* use fv3atm from PR 1612

* Changed UGWP diagnostic variable declaration intents from out to inout

* Docs/faqupdate (#8)

Co-authored-by: Denise Worthen <[email protected]>
Co-authored-by: jkbk2004 <[email protected]>
Co-authored-by: Brian Curtis <[email protected]>
* MOM6 writes restarts in YYYYMMDD.HHMMSS.MOM*nc format
* the final restart is timestamped
* make changes in scripts to remove 'suffix-hours' strings

* remove STORE_CORIOLIS from MOM_input templates

* add timestamp in the end forecast restart filenames for GFS

* FV3atm restart filename format
* Update FV3

* Merge pull request #67 from dustinswales/accumulated_cleanup

* Updated physics

* Reverting DISKNM/gaea to original

* add new BL_DATE
* Faster Compile option turned on for a compile and test per project

* added sample tests from each project to be tested with faster compile

* HAFS app to be compiled with 64bit
climbfuji and others added 30 commits August 8, 2024 09:28
…s arrays (#2183)

* UFSWM - In fv3atm and submodules, convert internal GFS DDTs from blocked data structures to contiguous arrays. This excludes the (external) `GFS_extdiag` and `GFS_restart` DDTs.
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - Convert GFS DDTs from blocked data structures to contiguous arrays (not including GFS_restart and GFS_extdiag DDTs)
    * ccpp-physics - Convert GFS DDTs from blocked data structures to contiguous arrays (affects `GFS_debug.{F90,meta} only`)
    * atmos_cubed_sphere - Convert GFS DDTs from blocked data structures to contiguous arrays and remove IPD_Data super DDT
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * stochastic_physics -
… FV3 diag table documentation #2277 + SKEB fix with d_con = zero #2374 (#2278)

* UFSWM - python scripts for yaml and rocoto-xml conversion, experiment setup, and test log output  
* Add python superlint option
* Documentation update: doc/UsersGuide/source/tables/fv3_diag_table.rst
    * FV3 - 
    * atmos_cubed_sphere - bugfix: allocates heat_source when skeb is True and d_con is zero
* using MOM6 test branch
      add MOM_dynamics_split_RK2b.F90 and MOM_EOS_base_type.F90 in cmake list
      add extra 8PE for cpld_debug_pdlib job
      set DEFAULT_ANSWER_DATE=20231231 in 5x5 case
      add USE_HUYNH_STENCIL_BUG = True in MOM_input
      using MOM6 restart file as BL for sfs and hafs_mom jobs

* remove USE_HUYNH_STENCIL_BUG = True in MOM_input
  switch FIX_USTAR_GUSTLESS_BUG=F to USTAR_GUSTLESS_BUG=T

* switch FIX_USTAR_GUSTLESS_BUG to USTAR_GUSTLESS_BUG for MOM_input_hafs

* set USE_HUYNH_STENCIL_BUG = True
)

* UFSWM - Update the MOM_input templates and RT scripts to allow use of downscaled MOM6 and CICE6 warmstarts.

* update script variables and sfs test
* UFSWM - update g2tmpl library, g2 library, UPP hash. Sync parm files with new UPP version.
  * FV3 - update inline post for UPP, point UPP submodule to head of develop, revise spack.yaml
…ng in rt.sh (2388) + Add ability to read increment files on native cubed sphere grid (2304) (#2389)

* UFSWM -  Unify CDEPS gfs, cfsr, and gefs datm datamodes. Add ability to read increment files on native cubed sphere grid.  Update rt scripts to fix checking the job exit status from Slurm and PBS schedulers.
  * FV3 - Add namelist parameter for cubed sphere increment read and update atmos_cubed_sphere hash for GFDL 
    Atmospheric Cubed Sphere PR #[342](NOAA-GFDL/GFDL_atmos_cubed_sphere#342)
     * atmos_cubed_sphere - Add ability to read increments from files on native cubed sphere grid
  * CDEPS - Unify CDEPS gfs, cfsr, and gefs datm datamodes. Rename CDEPS-related FILENAME_BASE to FILEBASE_DATM in 
     tests. Sunset gfs_hafs datamode.
…3/SAS/MYNN fix) (#2408)

* UFSWM - Refactor NRL h2o photochemical scheme; add "tendency_of_vertically_diffused_tracer_concentration" as output 
     from the MYNN PBL scheme
  * FV3 - Refactor NRL h2o photochemical scheme; add "tendency_of_vertically_diffused_tracer_concentration" as output from 
     the MYNN PBL scheme
      * ccpp-physics - Refactor NRL h2o photochemical scheme; add "tendency_of_vertically_diffused_tracer_concentration" as 
         output from the MYNN PBL scheme
…Switch to using Aux history files in atm_ds2s_docn_dice test; Remove IFI tests (was #2417) (#2395)

* UFSWM - 
  * CMEPS - fix aux history functionality; sync with ESCOMP
  * UFSWM - use auxiliary history files as input for atm_ds2s_docn_dice; remove the IFI tests
 *MOM6 - update MOM6 to its main repo. 20240824 updating (GFDL's FMA PR)
* UFSWM - Update default parameter values for damping based off of work done for GW
* UFSWM - The fire_behavior component has been added and a new application created 'ATMF'. This work also includes a new regression test 'cpld_regional_atm_fbh' for testing two-way coupling of the atm component (fv3atm) and fbh component (fire_behavior)
  * CMEPS - CMEPS required modifications to be aligned with the changes to the ccpp physics package
  * FV3 - the fv3 cap has been modified to export atmosphere forcing data to the fire component when 'cpl_fire' is set to true. It will also import new fields for physics.
    * ccpp-physics - the ccpp physics package has been modified to add heat fluxes, upward specific humidity flux, and a smoke tracer from the fire component.
…#2430)

* UFSWM - Use EMC/CICE:develop branch from CICE-Consortium:main
  * CICE - Use EMC/CICE:develop branch from CICE-Consortium:main
…to fms/2024.01 (#2431)

* UFSWM - Bump libraries on WCOSS2 to ip/4.0.0 w3emc/2.12.0 and fms/2024.01

* Adjust FMS location and bump ufs_common.lua

* Acorn lua update for fms bump, remove ifi library load
* UFSWM -  Add support for Intel LLVM compiler
  * CICE -  Add support for Intel LLVM compiler
  * FV3 -  Add support for Intel LLVM compiler
    * ccpp-physics -  Add support for Intel LLVM compiler
    * atmos_cubed_sphere -  Add support for Intel LLVM compiler 
    * upp -  Add support for Intel LLVM compiler 
  * WW3 - Add support for Intel LLVM compiler
* UFSWM - Add forecast day output for CICE via timestep stream
* UFSWM - Adds GFDL Land Model version 4 (LM4) as a component model, functional in Data Atmosphere mode
  * CMEPS - Small modifications for coupling of LM4
 * LM4-NUOPC driver - new model component hosted at github.com/NOAA-GFDL/LM4-NUOPC-driver. NUOPC Cap for LM4
   * LM4.0 - submodule of LM4 NUOPC driver, hosted at https://github.com/NOAA-GFDL/LM4/
* UFSWM - physics updates for RRFS.v1 code freeze
  * FV3 - physics updates for RRFS.v1 code freeze
    * ccpp-physics - physics updates for RRFS.v1 code freeze
* apply gaea job card fix for MPI issue: FI_VERBS_PREFER_XRC
…ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) #2464 + Update chunksizes for cubed sphere grid #2465 (#2463)

* UFSWM - 
  Update LND I/O docs
  Add fd_ufs.yaml docs
  Add tests-dev docs
* UFSWM - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles.
   * FV3 - Change the default chunking for the cubed sphere history files to use only the horizontal grid size of each of the tiles.
   * FV3 - Submodule pointer update for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py)

---------

Co-authored-by: Dusan Jovic <[email protected]>
Co-authored-by:  Dom Heinzeller <[email protected]>
* UFSWM - Modify global_control.nml to add compatibility with Global Workflow
* UFSWM - Updates cpld_control_sfs to use the most up-to-date configuration specs
* UFSWM - Update units attributes in netCDF output to be machine-readable
  * FV3 - Update units attributes in netCDF output to be machine-readable
    * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable
…n PR from production/RRFS.v1 #2481 (#2458)

* UFSWM - Enable some of the intel llvm tests in rt conf
* UFSWM - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables 
  * FV3 - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables
    * ccpp-physics - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables

---------

Co-authored-by: Grant Firl <[email protected]>
… CAPE cases + #2459 (#2461)

* UFSWM - Add tests-dev ATM-only idealized dry baroclinic wave test and a 2020 July CAPE case
* UFSWM - Update modulefile to support Rocky 8 on CSPs, with ParallelWorks

---------

Co-authored-by: Wei Huang <[email protected]>
Co-authored-by: Jong Kim <[email protected]>
* UFSWM - add PIO settings to WAV attributes in ufs.configure templates
* UFSWM - update ww3_shel.nml to allow for the ice field to be written to the restart file when required (i.e, waves in the slow loop)
* UFSWM - add WW3 restart files to comparison lists
  * WW3 - Add netCDF PIO capability for restarts and run-time history
* UFSWM 
  * FV3
    * ccpp-physics - Add Incremental Analysis Update (IAU) capability to update soil temperature and moisture for CCPP's NoahMP land model
… (#2489)

* UFSWM - Documentation for HSD cases 
  * FV3 - 
    * upp - update upp hash to ce258fca with update inline post interface. 

---------

Co-authored-by: gspetro-NOAA <[email protected]>
Co-authored-by: cameronbook <[email protected]>
* UFSWM - Thompson-Eidhammer microphysics code formatting
  * FV3 - Thompson-Eidhammer microphysics code formatting
    * ccpp-physics - Thompson-Eidhammer microphysics code formatting
* UFSWM - Update CICE to Consortium/main (2024-11). Expose hist_suffix for CICE ice_in
  * CICE - Update CICE to Consortium/main (2024-11)
…WW3 to avoid build errors #2512 (#2483)

* UFSWM - MYNN PBL, Smoke and subgrid cloud fraction.
  * FV3 - MYNN PBL, Smoke and subgrid cloud fraction.
    * ccpp-physics - MYNN PBL, Smoke and subgrid cloud fraction.
    * atmos_cubed_sphere - hail diagnostics, and average of smoke/dust.
  * WW3 -  Updated to add PIO switch to avoid build error
* UFSWM - Flexible restart write times (restart_fh) for med, ocn, ice, wav
  * CICE - Flexible restart write times (restart_fh)
  * CMEPS - Flexible restart write times (restart_fh)
  * MOM6 - Flexible restart write times (restart_fh)
  * WW3 - Flexible restart write times (restart_fh)
… on GW specs (#2528) + Sync with ESCOMP/CMEPS (#2469)

* UFSWM - Sync with ESCOMP/CDEPS (2024-12).  Sync with ESCOMP/CMEPS (2024-12). Make additional changes to global_control.nml.IN based on GW needs. 
  * CDEPS - Sync with ESCOMP/main (2024-12)
  * CMEPS - Sync with ESCOMP/main (2024-12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.