Remove.flake #58
Open
Remove.flake #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one looks fine. Please keep doing to the other subroutines heavily involved flake such as GFS_surface_composites_pre.F90 |
|
@AnilKumar-NOAA change the target branch to whatever you used for the baseline (flake.baseline?) so that the PR doesn't include all the code advances in Helin's develop |
|
I have asked Anil to start with the current develop branch. I will update
the flake.baseline for him to use as a target.
…On Tue, Mar 14, 2023 at 8:32 AM Michael Barlage ***@***.***> wrote:
@AnilKumar-NOAA <https://github.com/AnilKumar-NOAA> change the target
branch to whatever you used for the baseline (flake.baseline?) so that the
PR doesn't include all the code advances in Helin's develop
—
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALPHKYAH7PQRZZ6WIPG7VZDW4BQOJANCNFSM6AAAAAAVZE3SAQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
I have created flake.ccpp-physics as a target |
|
Thanks Helin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing flake model from ccpp/physics
the Variables used in the flakes related code are use_flake, lkm, lake mainly.
Small code removal for lake and followed by RT test.
RT test compared with baseline results to make sure that nothing changes removing flake related code.
GFS_surface_composites_pre.F90
removed flake code 241-251 ln.
RT test done and looks fine.