Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angle, scale and origin on FlxStrip #2973

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

MaybeMaru
Copy link
Contributor

No description provided.

if (angle != 0)
{
_cos = FlxMath.fastCos(angle * FlxAngle.TO_RAD);
_sin = FlxMath.fastSin(angle * FlxAngle.TO_RAD);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you be willing to compare this with using Math.sin and cos to see if the lack of precision actually a noticeable difference, be sure to try angles > 360, too please

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the rest, but I'd still like you to test the precision of FastSin and cos

Copy link
Member

@Geokureli Geokureli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks Flash targets, also requested other changes via comments

Also please provide a small, complete example that showcases the new features of this change

@Geokureli
Copy link
Member

would these changes conflict with this?
#3005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants