Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frame Collections not being destroyed #2929

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NeeEoo
Copy link
Contributor

@NeeEoo NeeEoo commented Oct 2, 2023

Unsure if this causes any crashes elsewhere so thats why this is a draft

Btw FlxImageFrame got edited because frames gets destroyed in super.destroy()

@NeeEoo
Copy link
Contributor Author

NeeEoo commented Oct 2, 2023

If you use a graphic that has been destroyed it causes this error

Called from flixel.animation.FlxAnimationController::update flixel/animation/FlxAnimationController.hx line 93
Called from flixel.animation.FlxAnimation::update flixel/animation/FlxAnimation.hx line 223
Called from flixel.animation.FlxAnimation::set_curFrame flixel/animation/FlxAnimation.hx line 267
Called from flixel.animation.FlxBaseAnimation::set_curIndex flixel/animation/FlxBaseAnimation.hx line 36
Called from flixel.animation.FlxAnimationController::set_frameIndex flixel/animation/FlxAnimationController.hx line 751
Called from flixel.FlxSprite::set_frame flixel/FlxSprite.hx line 1469

(line numbers might be off a little bit since found this on a bit older version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant