Encode long strings

Havret · Apr 16, 2024 · 4e2d5a3 · 4e2d5a3
1 parent 0572011
commit 4e2d5a3
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 0 deletions.
diff --git a/src/ArtemisNetCoreClient/ArtemisBinaryConverter.cs b/src/ArtemisNetCoreClient/ArtemisBinaryConverter.cs
@@ -177,6 +177,15 @@ public static int WriteString(ref byte destination, string value)
         }
         else
         {
+            offset += WriteInt32(ref destination.GetOffset(offset), value.Length << 1);
+            foreach (var c in value)
+            {
+                // Low byte
+                offset += WriteByte(ref destination.GetOffset(offset), (byte) (c & 0xFF)); 
+
+                // High byte
+                offset += WriteByte(ref destination.GetOffset(offset), (byte) ((c >> 8) & 0xFF));
+            }
         }
 
         return offset;

diff --git a/test/ArtemisNetCoreClient.Tests/ArtemisBinaryConverterSpec.cs b/test/ArtemisNetCoreClient.Tests/ArtemisBinaryConverterSpec.cs
@@ -154,4 +154,21 @@ public void should_decode_medium_string()
         Assert.Equal("abcdefghijkl", value);
         Assert.Equal(byteBuffer.Length, readBytes);
     }
+
+    [Fact]
+    public void should_encode_long_string()
+    {
+        // Arrange
+        var str = Enumerable.Repeat(0, 513).Aggregate("", (s, _) => s + "abcdefgh");
+        var byteCount = ArtemisBinaryConverter.GetStringByteCount(str);
+        var byteBuffer = new byte[byteCount];
+
+        // Act
+        var writtenBytes = ArtemisBinaryConverter.WriteString(ref byteBuffer.AsSpan().GetReference(), str);
+
+        // Assert
+        var expected = File.ReadAllText("long_encoded_string.txt").Split(",").Select(byte.Parse).ToArray();
+        Assert.Equal(expected, byteBuffer);
+        Assert.Equal(byteCount, writtenBytes);
+    }    
 }
diff --git a/test/ArtemisNetCoreClient.Tests/ArtemisNetCoreClient.Tests.csproj b/test/ArtemisNetCoreClient.Tests/ArtemisNetCoreClient.Tests.csproj
@@ -27,4 +27,10 @@
       <ProjectReference Include="..\..\src\ArtemisNetCoreClient\ArtemisNetCoreClient.csproj" />
     </ItemGroup>
 
+    <ItemGroup>
+      <None Update="long_encoded_string.txt">
+        <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+      </None>
+    </ItemGroup>
+
 </Project>
diff --git a/test/ArtemisNetCoreClient.Tests/long_encoded_string.txt b/test/ArtemisNetCoreClient.Tests/long_encoded_string.txt