Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 rename plugin, regex match and replace with access to more vars. #570

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

emorris00
Copy link

No description provided.

@emorris00
Copy link
Author

emorris00 commented Dec 8, 2023

The new plugin relies on lodash which it doesn't seem to have access to normally. On my test machine I symlinked the node_modules directory from Tdarr_Server to server/Tdarr/Plugin/FlowPlugins. So something will need to be figured out. I'll leave this in draft mode for now as it will probably need to be updated to require a higher version.

@emorris00 emorris00 marked this pull request as ready for review January 3, 2024 01:09
@emorris00
Copy link
Author

Tested your changes locally and it seems to work

@emorris00
Copy link
Author

@HaveAGitGat What still needs to be done to get this released?

@HaveAGitGat
Copy link
Owner

There is an existing templating system e.g. https://docs.tdarr.io/docs/plugins/flow-plugins/basics#plugin-variable-templating

So don't need to add a new one, can use {{{args.inputFileObj.video_resolution}}} instead of ${args.inputFileObj.video_resolution} unless there's something I've missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants