Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-candidate: v0.31.0-rc.1 #482

Merged
merged 13 commits into from
Sep 11, 2024
Merged

Release-candidate: v0.31.0-rc.1 #482

merged 13 commits into from
Sep 11, 2024

Conversation

luislhl
Copy link
Contributor

@luislhl luislhl commented Aug 30, 2024

r4mmer and others added 12 commits August 8, 2024 10:06
* feat: allow wallets on error state for stop API

* chore: linter changes

* tests: stop on errored wallet

* tests: do not stop on some wallet states
* feat: logger middleware

* feat: change all console calls to use logger instead

* chore: linter rule no-console should be error for src files

* fix: call logger.error instead of logger

* feat: build a fireblocks signer method with a logger instance

* chore: linter changes

* feat: show wallet-id for uninitialized wallets
* chore: rename master tag

* chore: also include staging tag
@luislhl luislhl self-assigned this Aug 30, 2024
@luislhl luislhl requested review from r4mmer and tuliomir and removed request for pedroferreira1 August 30, 2024 21:35
tuliomir
tuliomir previously approved these changes Sep 2, 2024
r4mmer
r4mmer previously approved these changes Sep 6, 2024
* feat: custom logger for lib

* chore: bump lib v1.12.1
@r4mmer r4mmer dismissed stale reviews from tuliomir and themself via 31d66b1 September 6, 2024 21:54
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (e44ff5d) to head (31d66b1).
Report is 16 commits behind head on release-candidate.

Files with missing lines Patch % Lines
...rc/controllers/fireblocks/fireblocks.controller.js 70.00% 3 Missing ⚠️
src/services/logger.service.js 91.89% 3 Missing ⚠️
src/controllers/index.controller.js 60.00% 2 Missing ⚠️
src/helpers/tx.helper.js 33.33% 2 Missing ⚠️
src/services/fireblocks.service.js 66.66% 2 Missing ⚠️
src/app.js 66.66% 1 Missing ⚠️
src/controllers/hsm/hsm.controller.js 88.88% 1 Missing ⚠️
src/services/wallets.service.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release-candidate     #482      +/-   ##
=====================================================
+ Coverage              89.59%   89.88%   +0.28%     
=====================================================
  Files                     51       53       +2     
  Lines                   2173     2245      +72     
  Branches                 413      420       +7     
=====================================================
+ Hits                    1947     2018      +71     
- Misses                   209      210       +1     
  Partials                  17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luislhl luislhl merged commit a79ac45 into release-candidate Sep 11, 2024
14 checks passed
@luislhl luislhl mentioned this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants