Skip to content

Commit

Permalink
README - Require "latest version" of svgo to contribute
Browse files Browse the repository at this point in the history
  • Loading branch information
@HatScripts
HatScripts authored Dec 27, 2022
1 parent a6cb75c commit c9eed38
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ npm install --save https://github.com/HatScripts/circle-flags

## Contributing

To contribute, you need to have [svgo](https://github.com/svg/svgo) installed
(version 2.3.1 or newer).
To contribute, you need to have the latest version of [svgo](https://github.com/svg/svgo) installed.

First, edit the relevant SVG files in the `flags/` directory.

Expand Down

3 comments on commit c9eed38

@waldyrious
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HatScripts I think it's better to mention a specific version or version range that's been tested to work, in case they introduce breaking changes that invalidate this statement. E.g. #93.

@HatScripts
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldyrious That's a good point. But doesn't the "or newer" part kind of undermine what you are suggesting?

@waldyrious
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's continue this discussion in a proper issue thread :) I've opened #99.

Please sign in to comment.