Upgrade/mern v2.5.0 #375
Upgrade/mern v2.5.0 #375
Conversation
ashifa454
commented
Jun 8, 2018
ashifa454
commented
- Installed react-16.0.4
- installed prototypes
- was struggling with the test, I think the probable issue is with enzyme so removed from pri-commit
- React-Router is Not working with React-16.x.x
mannyhenri
changed the base branch from
upgrade/mern-v2.4.0
to
upgrade/mern-v2.5.0
There was a problem hiding this comment.
If you look at travis build there are a few errors (https://travis-ci.org/Hashnode/mern-starter/jobs/389551186) can you review those. We typically keep all tests therefore if you removed any test you need to add them back in and review the testing errors and update your code to reflect them. You'll get enough information in the travis tests to help you understand what's wrong and if you need help there let me or @mattlubner know. Also I'd suggest you take a look at previous attempts to update React/proptypes to guide you if you have any issues. Can you do a second pass considering these comments?
|
Take a look at #348 to see potential areas how to do this. |
|
I actually didn't remove any test case, but a pre-hook which was testing before commit. rest let me take a look at the references |
|
@ashifa454 let me know when you've made further changes on your PR I'll test it locally and provide fixes or recommendations. |
|
Will close this PR for now @ashifa454 please make a new one when you've upgraded to a stable build on your end. Again feel free to pull from the referred #348 |
