Controller joysticks #416
Controller joysticks #416
Conversation
| @@ -8,6 +8,7 @@ import { ItemType, type ItemDefinition } from "@common/utils/objectDefinitions"; | |||
| import { Vec } from "@common/utils/vector"; | |||
| import $ from "jquery"; | |||
| import nipplejs, { type JoystickOutputData } from "nipplejs"; | |||
| import * as PIXI from "pixi.js"; | |||
There was a problem hiding this comment.
please do not import everything from pixijs
There was a problem hiding this comment.
Done, now it only imports ticker
| @@ -342,6 +343,50 @@ export class InputManager { | |||
| shootOnRelease = false; | |||
| }); | |||
| } | |||
| const ticker = new PIXI.Ticker(); | |||
There was a problem hiding this comment.
use Game class's pixi ticker
| const ticker = new PIXI.Ticker(); | ||
| ticker.stop(); | ||
| ticker.add(() => { | ||
| const gamepads = navigator.getGamepads(); |
There was a problem hiding this comment.
if you use Game's pixi ticker, put this into its own method
| const gamepads = navigator.getGamepads(); | ||
| if (gamepads[0]) { | ||
| const leftJoystickMoving = gamepads[0].axes[0] !== 0 || gamepads[0].axes[1] !== 0; | ||
| const rightJoystickMoving = gamepads[0].axes[2] !== 0 || gamepads[0].axes[3] !== 0; |
There was a problem hiding this comment.
rest in peace stick drift controllers
There was a problem hiding this comment.
Perhaps there could be a sensitivity setting to adjust when the JoystickMoving vars are considered true
| ticker.stop(); | ||
| ticker.add(() => { | ||
| const gamepads = navigator.getGamepads(); | ||
| if (gamepads[0]) { |
There was a problem hiding this comment.
allow players to select their gamepad
| const rightJoystickMoving = gamepads[0].axes[2] !== 0 || gamepads[0].axes[3] !== 0; | ||
| // const rightJoystickDistance = Math.sqrt(gamepads[0].axes[2] * gamepads[0].axes[2] + gamepads[0].axes[3] * gamepads[0].axes[3]); | ||
| // distance formula for stuff like throwables, USAS-12, and M590M | ||
| if (leftJoystickMoving) { |
There was a problem hiding this comment.
probably best to allow players to configure which joystick to use for what
| this.turning = true; | ||
| const activePlayer = game.activePlayer; | ||
| if (game.console.getBuiltInCVar("cv_responsive_rotation") && !game.gameOver && game.activePlayer) { | ||
| game.activePlayer.container.rotation = this.rotation; |
There was a problem hiding this comment.
isn't there a better way to do this in the Player class?
| const ticker = new PIXI.Ticker(); | ||
| ticker.stop(); | ||
| ticker.add(() => { | ||
| const gamepads = navigator.getGamepads(); |
There was a problem hiding this comment.
do you really need to call this method every frame, is it required?
fix: only imported ticker instead of all of pixi.js
| @@ -8,7 +8,7 @@ import { ItemType, type ItemDefinition } from "@common/utils/objectDefinitions"; | |||
| import { Vec } from "@common/utils/vector"; | |||
| import $ from "jquery"; | |||
| import nipplejs, { type JoystickOutputData } from "nipplejs"; | |||
| import * as PIXI from "pixi.js"; | |||
| import { Ticker } from "pixi.js"; | |||
There was a problem hiding this comment.
this is still wrong, use the Game update method
*Not using requestAnimationFrame anymore